-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DQM] Update visDQMUpload.py to pyhon3 #34424
Conversation
This change avoids derecation warnings in python3: visDQMUpload.py:39: DeprecationWarning: key_file, cert_file and check_hostname are deprecated, use a custom context instead. HTTPS.__init__(self, host, key_file = ssl_key_file, cert_file = ssl_cert_file, **kwargs)
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34424/23834
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-649b23/16652/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
@slava77 , @davidlange6 , @makortel looks like #34409 has fixed the reco comparison diff ( #34424 (comment) ) |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This change avoids derecation warnings in python3:
visDQMUpload.py:39: DeprecationWarning: key_file, cert_file and check_hostname are deprecated, use a custom context instead.
HTTPS.init(self, host, key_file = ssl_key_file, cert_file = ssl_cert_file, **kwargs)
PR validation:
Tested locally with usual user grid certificate, I assume no issues will arise in production....